Issue 39004: Fix for issues 137 and 138.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 39004: Fix for issues 137 and 138. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 years, 3 months ago by bmcquade

Modified:
2 years, 3 months ago

Reviewers:
Sam Kerner

CC:
page-speed-codereview_googlegroups.com

Base URL:
http://page-speed.googlecode.com/svn/firefox_addon/trunk/

Visibility:
Public.

Description

No idea why this fixes the issue, but it does. You might think that re-ordering
the tests causes the first test to return early, preventing the second test from
running, but in fact the same return path is used regardless of the order of the
tests. I have no idea why this fixes the issue but it does. I'd like to get this
checked in and pushed asap, and then follow up with mozilla to see if they
understand what's going on here.

Patch Set 1

Created: 2 years, 3 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/js/components/componentCollectorService.js	View		1 chunk	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM.

I approve in the interest of fixing this ASAP, but I think it is worth figuring
out what is going on, so that we can avoid it in the future.

Sam

Expand All Messages | Collapse All Messages