Issue 736001: Move redirect chain computation from RuleInput to ResourceCollection.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 736001: Move redirect chain computation from RuleInput to ResourceCollection. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year ago by bmcquade

Modified:
11 months, 2 weeks ago

Reviewers:
mdsteele, lsong, aoates, MikeS

CC:
page-speed-codereview_googlegroups.com

Base URL:
http://page-speed.googlecode.com/svn/lib/trunk/src/

Visibility:
Public.

Description

The motivation for this is that some parts of the codebase (namely browsing
context generation) want access to redirect chains, but browsingcontext doesn't
have access to RuleInput.

Patch Set 1

Created: 1 year ago

Download raw patch set

	Unified diffs	Side-by-side diffs	Stats			Patch
M	pagespeed/core/resource_collection.cc	View	5 chunks	+174 lines, -0 lines	0 comments	Download
M	pagespeed/core/resource_collection.h	View	4 chunks	+35 lines, -0 lines	0 comments	Download
M	pagespeed/core/resource_collection_test.cc	View	2 chunks	+150 lines, -1 line	0 comments	Download
M	pagespeed/core/rule_input.cc	View	2 chunks	+0 lines, -170 lines	0 comments	Download
M	pagespeed/core/rule_input.h	View	3 chunks	+0 lines, -18 lines	0 comments	Download
M	pagespeed/core/rule_input_test.cc	View	1 chunk	+37 lines, -156 lines	0 comments	Download
M	pagespeed/rules/make_landing_page_redirects_cacheable.cc	View	5 chunks	+8 lines, -9 lines	0 comments	Download
M	pagespeed/rules/minimize_dns_lookups.cc	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	pagespeed/rules/minimize_redirects.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	pagespeed/rules/serve_scaled_images.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	pagespeed/rules/specify_image_dimensions.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pagespeed/testing/pagespeed_test.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	pagespeed/testing/pagespeed_test.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages